karim/RAPPORT-HOST
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(admin): separates Admin-Login statt is_admin-Flag

Browse Source 
Auf Wunsch: Betreiber-Bereich getrennt von Kundenkonten.
- auth.js: signAdminToken (role:operator), requireAdmin prüft Token-Rolle;
  requireAuth weist Operator-Token ab (saubere Trennung beide Richtungen)
- routes/admin.js: POST /admin/login (ADMIN_PASSWORD → Operator-Token)
- env.js: adminPassword statt adminEmail
- 0003_admin.sql: droppt die nicht mehr genutzte accounts.is_admin-Spalte
- register/login/account/me: is_admin restlos entfernt

E2E: Kunde→403, falsches PW→401, richtiges PW→Token, stats→200,
Admin-Token→Kundenroute→401.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
karim
2026-05-31 10:43:47 +02:00
parent 2d850638f2
commit 540dd9df5b
6 changed files with 71 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/routes/auth.js
+23 -18
View File
@@ -1,36 +1,41 @@
// HOST-Konten: Registrierung + Login. Gibt ein JWT zurück.
// HOST-Kundenkonten: Registrierung + Login. Gibt ein JWT zurück.
import { Router } from "express";
import { one } from "../db.js";
import { hashPassword, verifyPassword, signToken, ensureAdminFlag } from "../auth.js";
import { hashPassword, verifyPassword, signToken } from "../auth.js";
export const authRouter = Router();
const isEmail = (s) => /.+@.+\..+/.test(s || "");
authRouter.post("/register", async (req, res) => {
const { email, password } = req.body || {};
const email = (req.body?.email || "").trim().toLowerCase();
const password = req.body?.password || "";
if (!isEmail(email)) return res.status(400).json({ error: "Ungültige Email." });
if (!password || password.length < 8) return res.status(400).json({ error: "Passwort min. 8 Zeichen." });
if (password.length < 8) return res.status(400).json({ error: "Passwort min. 8 Zeichen." });
const existing = await one("select id from accounts where email = $1", [email.toLowerCase()]);
const existing = await one("select id from accounts where email = $1", [email]);
if (existing) return res.status(409).json({ error: "Konto existiert bereits." });
const account = await one(
"insert into accounts (email, password_hash) values ($1, $2) returning id, email, is_admin",
[email.toLowerCase(), await hashPassword(password)]
);
account.is_admin = await ensureAdminFlag(account);
res.json({ token: signToken(account), account: { id: account.id, email: account.email, is_admin: account.is_admin } });
let account;
try {
account = await one(
"insert into accounts (email, password_hash) values ($1, $2) returning id, email",
[email, await hashPassword(password)]
);
} catch (e) {
// 23505 = unique_violation (Race zwischen SELECT und INSERT).
if (e.code === "23505") return res.status(409).json({ error: "Konto existiert bereits." });
throw e;
}
res.json({ token: signToken(account), account: { id: account.id, email: account.email } });
});
authRouter.post("/login", async (req, res) => {
const { email, password } = req.body || {};
const account = await one("select id, email, password_hash, is_admin from accounts where email = $1", [
(email || "").toLowerCase(),
]);
if (!account || !(await verifyPassword(password || "", account.password_hash))) {
const email = (req.body?.email || "").trim().toLowerCase();
const password = req.body?.password || "";
const account = await one("select id, email, password_hash from accounts where email = $1", [email]);
if (!account || !(await verifyPassword(password, account.password_hash))) {
return res.status(401).json({ error: "Email oder Passwort falsch." });
}
account.is_admin = await ensureAdminFlag(account);
res.json({ token: signToken(account), account: { id: account.id, email: account.email, is_admin: account.is_admin } });
res.json({ token: signToken(account), account: { id: account.id, email: account.email } });
});